Skip to content

fix typos #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2024
Merged

fix typos #508

merged 1 commit into from
Oct 6, 2024

Conversation

@spaette
Copy link
Contributor

@spaette spaette commented Sep 26, 2024 •
edited
Loading

cf: https://github.com/ararslan/FrankenTuples.jl

docs/src/reference.md

replaced Frakentuples with camel case FrankenTuples

another possible change might be kind'ed

$ grep -nr kinded JuliaSyntax.jl
JuliaSyntax.jl/src/parse_stream.jl:12:# Token flags - may be set for operator kinded tokens
$

@spaette spaette marked this pull request as ready for review September 28, 2024 15:31
@codecov
Copy link

codecov bot commented Sep 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (30109d4) to head (6a2500a).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   96.18%   96.19%   +0.01%     
==========================================
  Files          13       13              
  Lines        4032     4253     +221     
==========================================
+ Hits         3878     4091     +213     
- Misses        154      162       +8
Flag Coverage Δ
96.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spaette
Copy link
Contributor Author

spaette commented Sep 28, 2024 •
edited
Loading

@KristofferC

This is the pull mentioned over in the Tokenize.jl repo ticket.

At minimum for a non-native English speaker sometext might convey the meaning of the code more readily.

$ grep -nr somtext Tokenize.jl | sed 1q
Tokenize.jl/test/lexer.jl:186:    @test tok("somtext true", 3).kind == T.TRUE
$ grep -nr somtext JuliaSyntax.jl | sed 1q
JuliaSyntax.jl/test/tokenize.jl:201:    @test tok("somtext true", 3).kind == K"Bool"
$

c42f
c42f reviewed Oct 6, 2024
View reviewed changes
c42f
c42f approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks :)

@c42f c42f merged commit 37a1b9c into JuliaLang:main Oct 6, 2024
37 checks passed
c42f pushed a commit to JuliaLang/julia that referenced this pull request Oct 17, 2025
@spaette
Fix typos in comments and docs (JuliaLang/JuliaSyntax.jl#508)
85342c1 
Co-authored-by: spaette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c42f c42f c42f approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spaette @c42f